On Fri 2019-05-03 09:56:07, Johan Hovold wrote: > On Fri, May 03, 2019 at 11:40:15AM +1000, Tobin C. Harding wrote: > > On Thu, May 02, 2019 at 10:39:22AM +0200, Johan Hovold wrote: > > I am totally aware this is close to code churn and any discussion is > > bikeshedding ... for me just because loads of places don't do this it > > still looks nicer to my eyes > > > > /** > > * sfn() - Super awesome function. > > > > than > > > > /** > > */ sfn() - super awesome function > > > > I most likely will keep doing these changes if I am touching the > > kernel-doc comments for other reasons and then drop the changes if the > > subsystem maintainer thinks its code churn. > > > > I defiantly won't do theses changes in GNSS, GREYBUS, or USB SERIAL. > > This isn't about any particular subsystem, but more the tendency of > people to make up random rules and try to to force it on others. It's > churn, and also makes things like code forensics and backports harder > for no good reason. +1 But I could understand that it is hard to keep it as is when it bothers ones eyes. I tend to change these things as well and have to activelly stop myself again and again ;-) Best Regards, Petr
