On 12/18/18 10:18 AM, Joe Lawrence wrote:
On 12/18/2018 03:49 AM, Miroslav Benes wrote:
On Mon, 17 Dec 2018, Joe Lawrence wrote:
I'm just being picky about its documentation and how we should note its
usage in the v3 patch. Think that s/__noclone/used/g of the v2 commit
message would be sufficient?
We could rephrase it. After all it is not only about symbol names in the
symbol table. The traceable/patchable code has to be present...
"Sparse reported warnings about non-static symbols. For the variables
a simple static attribute is fine - for the functions referenced by
livepatch via klp_func the symbol-names must be unmodified in the
symbol table and the patchable code has to be emitted.
Attach __used attribute to the shared statically declared functions."
?
That works for me.
Hi Nicholas,
Did you still want to post a v3 for this fix? I think there were only a
few v3 suggestions (link tag, tag order, __used attribute, and commit
msg phrasing.)
The context has been clipped in the quoting above, so here's an archive
link if you need it:
https://lore.kernel.org/lkml/1544965657-26804-1-git-send-email-hofrat@xxxxxxxxx/
Thanks,
-- Joe
