On Wed, Feb 19, 2025 at 06:37:17AM +0100, Christoph Hellwig wrote: > On Tue, Feb 18, 2025 at 08:08:13PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > libxfs_buf_get_uncached doesn't take a daddr argument, so don't pass one > > as the flags argument. Also take the opportunity to use > > xfs_buf_set_daddr to set the actual disk address. > > Should it take a daddr argument? I've been wondering that a bit as the > interface that doesn't pass one seems a bit odd. We'd have to change the kernel first, there are libxfs callers with that signature. > The patch itself looks fine, although I don't really see the point in > the xfsprogs-only xfs_buf_set_daddr (including the current two callers). Eh, yeah. Want me to resend with those bits cut out? --D
