On Tue, Feb 18, 2025 at 08:08:13PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > libxfs_buf_get_uncached doesn't take a daddr argument, so don't pass one > as the flags argument. Also take the opportunity to use > xfs_buf_set_daddr to set the actual disk address. Should it take a daddr argument? I've been wondering that a bit as the interface that doesn't pass one seems a bit odd. The patch itself looks fine, although I don't really see the point in the xfsprogs-only xfs_buf_set_daddr (including the current two callers).