On Fri, Feb 14, 2025 at 07:20:54AM +0100, Christoph Hellwig wrote: > On Thu, Feb 13, 2025 at 02:09:43PM -0800, Darrick J. Wong wrote: > > > > I think you're supposed to have initialized reservation.entry already. > > > > > > What do you mean with that? > > > > I think the reservation was declared to be initialized as zeroes, but > > there was never an INIT_LIST_HEAD(&reservation.entry) to set the > > pointers to each other? > > Only the head of the list needs a INIT_LIST_HEAD, the entries which just > happen to use the list_head structure don't need any initialization out > of the list_add/list_add_tail call. Huh. Ok, that explains why despite people telling me to fix my code to do that, I've never gotten any of the warnings about broken list usage. --D
