Re: [PATCH] xfs: fix simplify extent lookup in xfs_can_free_eofblocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 02, 2024 at 08:11:17AM -0700, Christoph Hellwig wrote:
> > +	if (ip->i_delayed_blks)
> > +		found_blocks = true;
> > +	else if (xfs_iext_lookup_extent(ip, &ip->i_df, end_fsb, &icur, &imap))
> >  		found_blocks = true;
> 
> This could be simplified a little bit by doing:
> 
> 	if (ip->i_delayed_blks ||
> 	    xfs_iext_lookup_extent(ip, &ip->i_df, end_fsb, &icur, &imap))
>  		found_blocks = true;
> 
> but otherwise looks good:

Oops, heh, I thought I'd forgotten something. :(

V2 soon, though really there's a pile more fsdax corruption fixes so
heh.

> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Thanks!

--D




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux