On Wed, Aug 28, 2024 at 07:52:48AM +1000, Dave Chinner wrote: > I suspect that we'd do better to have explicit shutdown processing > of log items in the AIL (i.e. a ->iop_shutdown method) that is > called instead of ->iop_push when the AIL detects that the > filesystem has shut down. We can then define the exact behaviour we > want in this case and processing does not have to be non-blocking > for performance and latency reasons. > > If we go down that route, I think we'd want to add a > XFS_ITEM_SHUTDOWN return value after the push code calls > xfs_force_shutdown(). The push code does not error out the item or > remove it from the AIL, just shuts down the fs and returns > XFS_ITEM_SHUTDOWN. Yes, that seems even better. But it would probably be a fair amount of work.
