On Fri, Aug 23, 2024 at 07:04:37PM +0800, Long Li wrote: > After pushing log items, the log item may have been freed, making it > unsafe to access in tracepoints. This commit introduces XFS_ITEM_UNSAFE > to indicate when an item might be freed during the item push operation. So instead of this magic unsafe operation I think declaring a rule that the lip must never be accessed after the return is the much saner choice. We'll then need to figure out how we can still keep useful tracing without accessing the lip. The only information the trace points need from the lip itself are the type, flags, and lsn and those seem small enough to save on the stack before calling into ->iop_push.