Re: [PATCH 1/7] libfrog: hoist free space histogram code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 1/7] libfrog: hoist free space histogram code
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 2 Jul 2024 07:32:38 +0200
Cc: cem@xxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, hch@xxxxxx
In-reply-to: <171988118595.2007921.8810266640574883670.stgit@frogsfrogsfrogs>
References: <171988118569.2007921.18066484659815583228.stgit@frogsfrogsfrogs> <171988118595.2007921.8810266640574883670.stgit@frogsfrogsfrogs>
User-agent: Mutt/1.5.17 (2007-11-01)

> +struct histent
> +{

The braces goes to the previous line for our normal coding style.

Also the naming with histend/histogram the naming seems a bit too
generic for something very block specific.  Should the naming be
adjusted a bit?

Follow-Ups:
- Re: [PATCH 1/7] libfrog: hoist free space histogram code
  - From: Darrick J. Wong

References:
- [PATCHSET v30.7 05/16] xfs_scrub: use free space histograms to reduce fstrim runtime
  - From: Darrick J. Wong
- [PATCH 1/7] libfrog: hoist free space histogram code
  - From: Darrick J. Wong

Prev by Date: Re: [PATCH 7/8] xfs_scrub: don't trim the first agbno of each AG for better performance
Next by Date: Re: [PATCH 2/7] libfrog: print wider columns for free space histogram
Previous by thread: [PATCH 1/7] libfrog: hoist free space histogram code
Next by thread: Re: [PATCH 1/7] libfrog: hoist free space histogram code
Index(es):
- Date
- Thread

[Index of Archives] [XFS Filesystem Development (older mail)] [Linux Filesystem Development] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux RAID] [Linux SCSI]

Powered by Linux