On Mon, Jul 01, 2024 at 06:02:36PM -0700, Darrick J. Wong wrote: > Therefore, we created a second implementation that will walk the bnobt > and perform the trims in block number order. This implementation avoids > the worst problems of the original code, though it lacks the desirable > attribute of freeing the biggest chunks first. > > On the other hand, this second implementation will be much easier to > constrain the system call latency, and makes it much easier to report > fstrim progress to anyone who's running xfs_scrub. Skip the first block > of each AG to ensure that we get the sub-AG algorithm. I completely fail to understand how skipping the first block improves performance and is otherwise a good idea. What am I missing?