On Tue, Jun 18, 2024 at 10:25:49PM -0700, Christoph Hellwig wrote: > On Tue, Jun 18, 2024 at 06:06:22PM -0700, Darrick J. Wong wrote: > > NAK, this patch is still not correct -- if we add an attr fork here, we > > also have to xfs_add_attr(). ATTR protects attr forks in general, > > whereas ATTR2 only protects dynamic fork sizes. > > Yes. Note that I was kinda surprised we wouldn't always set the attr > bit by default in mkfs, but indeed we can create a file system without > attrs, which felt odd. Yeah. If you turn on parent pointers but don't use a protofile or turn on metadir in mkfs, then the fs you get actually won't have /any/ parent pointers in it at all. One of Allison's mkfs patches actually would turn on ATTR at format time, but the V5 sb verifier only requires ATTR2 (dynamic forkoff), not ATTR (a file has/had an attr fork). I guess I should document that in xfs_format.h, eh? :) --D
