On Tue, Jun 18, 2024 at 06:06:22PM -0700, Darrick J. Wong wrote: > NAK, this patch is still not correct -- if we add an attr fork here, we > also have to xfs_add_attr(). ATTR protects attr forks in general, > whereas ATTR2 only protects dynamic fork sizes. Yes. Note that I was kinda surprised we wouldn't always set the attr bit by default in mkfs, but indeed we can create a file system without attrs, which felt odd.