On Tue, Apr 09, 2024 at 04:16:45PM -0700, Darrick J. Wong wrote: > On Mon, Apr 08, 2024 at 04:54:53PM +0200, Christoph Hellwig wrote: > > xfs_bmap_add_extent_delay_real takes parts or all of a delalloc extent > > and converts them to a real extent. It is written to deal with any > > potential overlap of the to be converted range with the delalloc extent, > > but it turns out that currently only converting the entire extents, or a > > part starting at the beginning is actually exercised, as the only caller > > always tries to convert the entire delalloc extent, and either succeeds > > or at least progresses partially from the start. > > > > If it only converts a tiny part of a delalloc extent, the indirect block > > calculation for the new delalloc extent (da_new) might be equivalent to that > > of the existing delalloc extent (da_new). If this extent conversion now > > da_old? Yes.