On Tue, Apr 09, 2024 at 04:20:44PM -0700, Darrick J. Wong wrote: > > @@ -4542,6 +4532,15 @@ xfs_bmapi_write( > > */ > > bma.length = XFS_FILBLKS_MIN(len, XFS_MAX_BMBT_EXTLEN); > > > > + if (wasdelay) { > > + bma.offset = bma.got.br_startoff; > > + bma.length = bma.got.br_blockcount; > > This read funny since we'd previously set bma.{offset,length} above, but > I guess that preserves the "convert all the delalloc" behavior; and you > turn it off in patch 8, right? Yes. That being said I should just move the assignments into the other branch here to make things more obvious.