On Tue, Mar 26, 2024 at 06:50:47AM +0100, Christoph Hellwig wrote: > On Mon, Mar 25, 2024 at 05:02:37PM -0700, Darrick J. Wong wrote: > > > +/* > > > + * Some features are always on for v5 file systems, allow the compiler to > > > + * eliminiate dead code when building without v4 support. > > > + */ > > > +#define __XFS_HAS_V4_FEAT(name, NAME) \ > > > > Shouldn't this be called __XFS_HAS_V5_FEAT? > > They are features for v4 and unconditional for v5. Given that Dave > came up with the same names independently they can't be all bad, > although I don't really care very strongly. Ok, you've both persuaded me then. Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> --D
