Re: [PATCH 1/4] xfs_repair: define an in-memory btree for storing refcount bag info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 25, 2024 at 10:57:57PM -0700, Christoph Hellwig wrote:
> On Mon, Mar 25, 2024 at 09:01:50PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@xxxxxxxxxx>
> > 
> > Create a new in-memory btree type so that we can store refcount bag info
> > in a much more memory-efficient format.
> 
> There's probably a reason to not just shared this directly with the
> kernel?

Add to the commit message:

"The xfs_repair rcbag btree stores inode numbers (unlike the kernel
rcbag btree) because xfs_repair needs to compute the bitmap of inodes
that must have the reflink iflag set."

> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Thanks!

--D




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux