On Tue, Jan 02, 2024 at 03:13:30AM -0800, Christoph Hellwig wrote: > On Sun, Dec 31, 2023 at 12:07:03PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > Create the XFS_DIR3_FTYPE_STR macro so that we can report ftype as > > strings instead of numbers in tracepoints. > > Looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > But why not fold this into the patch actually using the macro? That patch has slowly been jumping ahead of other patches in djwong-dev as I've wanted it for symbolic decoding of ftypes. After a couple times of carefully cutting out that hunk of the patch to paste it into another earlier patch I decided it would be much easier to do: $ stg export -d foopatches/ $ vi foopatches/series Change: xfs-patch-001 xfs-patch-002 ... xfs-patch-300 xfs-dir2-create-ftype-strings-for-ftrace xfs-patch-301 Into: xfs-patch-001 xfs-dir2-create-ftype-strings-for-ftrace xfs-patch-002 ... xfs-patch-300 xfs-patch-301 :wq $ stg float -s foopatches/series $ <patch stack reordered with minimal work on my part> --D
