On Tue, Dec 19, 2023 at 09:00:38AM +1100, Dave Chinner wrote: > I'm not convinced this is correct behaviour. > > That is, we can get a real full filesystem ENOSPC even when project > quotas are on and the the project quota space is low. With this > change we will only flush project quotas rather than the whole > filesystem. Yes. > quotas are enabled. > > Hence my suggestion that we should be returning -EDQUOT from project > quotas and only converting it to -ENOSPC once the project quota has > been flushed and failed with EDQUOT a second time. FYI, my suggestion of turning cleared_space into a counter and still falling back to the normal ENOSPC clearing would also work. But in the long run moving this pretty messy abuse of ENOSPC for out of qupta in the low-level code into the highest syscall boudary is probably a good thing for maintainability.
