On Wed, Dec 13, 2023 at 09:00:39PM -0800, Christoph Hellwig wrote: > On Thu, Dec 14, 2023 at 10:41:34AM +0800, wuyifeng (C) wrote: > > Both xflag and iflag are log flags. We can use the bits of lflag to > > indicate all log flags, which is a small code reconstruction. > > I don't really see much of an upside here. This now requires me to > go out of the function to figure out what the flags means, and it adds > overly long lines making reading the code harder. Also, lflags is a bitset, so what does (LOG_EXT2INT|LOG_INT2EXT) mean? --D
