On Wed, Dec 06, 2023 at 09:30:19PM -0800, Christoph Hellwig wrote: > On Wed, Dec 06, 2023 at 06:41:10PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > Rebuild the free space btrees from the gaps in the rmap btree. > > Refer to the linked documentation for more details. > > > > Link: https://docs.kernel.org/filesystems/xfs-online-fsck-design.html#case-study-rebuilding-the-free-space-indices > > Nit: linking the file in the kernel tree that this is generated from it > and requires internet access would seem more useful. Er... assuming you are asking for a link to the file in the kernel tree from which the HTML is generated so as /not/ to require internet access, I'll add: "Link: Documentation/filesystems/xfs-online-fsck-design.rst" That said, I couldn't find any particular precedent in Documentation/ for having Link: tags in patches that point to paths underneath Documentation/ so I guess I'll just make s*** up like always, then wait and see how many auto-nag emails I get about how I've broken some random rule somewhere. :P --D > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> >
