On Wed, Dec 06, 2023 at 09:26:06PM -0800, Christoph Hellwig wrote: > On Wed, Dec 06, 2023 at 06:38:50PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > The btree bulkloading code calls xfs_buf_delwri_queue_here when it has > > finished formatting a new btree block and wants to queue it to be > > written to disk. Once the new btree root has been committed, the blocks > > (and hence the buffers) will be accessible to the rest of the > > filesystem. Mark each new buffer as DONE when adding it to the delwri > > list so that the next btree traversal can skip reloading the contents > > from disk. > > This still seems like the wrong place to me - it really is the caller > that fills it out that should set the DONE flag, not a non-standard > delwri helper that should hopefully go away in the future. I'll move it to xfs_btree_bload_drop_buf then. --D
