On Tue, Dec 05, 2023 at 06:56:42AM +0100, Christoph Hellwig wrote: > On Mon, Dec 04, 2023 at 09:50:28PM -0800, Darrick J. Wong wrote: > > How about these last couple of sentences? > > > > /* > > * The "LARP" (Logged extended Attribute Recovery Persistence) debugging knob > > * sets the XFS_DA_OP_LOGGED flag on all xfs_attr_set operations performed on > > * V5 filesystems. As a result, the intermediate progress of all setxattr and > > * removexattr operations are tracked via the log and can be restarted during > > * recovery. This is useful for testing xattr recovery prior to merging of the > > * parent pointer feature which requires it to maintain consistency, and may be > > * enabled for userspace xattrs in the future. > > */ > > Oooh. So all the logged attrs work is preparation for parent pointers? > That makes a whole lot of sense, but I've missed it so far. Yes, the > above comment is great. Yep! And that's coming in the year end megapatchbomb. :) --D > With that: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> >
