On Tue, Dec 05, 2023 at 06:38:42AM +0100, Christoph Hellwig wrote: > On Mon, Dec 04, 2023 at 09:36:07PM -0800, Darrick J. Wong wrote: > > +/* > > + * The "LARP" (Logged extended Attribute Recovery Persistence) debugging knob > > + * sets the XFS_DA_OP_LOGGED flag on all xfs_attr_set operations performed on > > + * V5 filesystems. As a result, the intermediate progress of all setxattr and > > + * removexattr operations are tracked via the log and can be restarted during > > + * recovery. > > + */ > > Can you also add a sentence on why we even have this code and why you'd > want to set the flag? How about these last couple of sentences? /* * The "LARP" (Logged extended Attribute Recovery Persistence) debugging knob * sets the XFS_DA_OP_LOGGED flag on all xfs_attr_set operations performed on * V5 filesystems. As a result, the intermediate progress of all setxattr and * removexattr operations are tracked via the log and can be restarted during * recovery. This is useful for testing xattr recovery prior to merging of the * parent pointer feature which requires it to maintain consistency, and may be * enabled for userspace xattrs in the future. */ --D
