On Thu, Nov 09, 2023 at 08:38:56AM -0800, Darrick J. Wong wrote: > Dave suggested that we might restore the pre-4.6 behavior by explicitly > encoding what we used to do: > > inode->i_atime.tv_sec = seq & 0xFFFFFFFF; > inode->i_atime.tv_nsec = seq >> 32; > > (There's a helper in 6.7 for this, apparently.) > > But then I pointed out that the entire rtpick sequence counter thing > merely provides a *starting point* for rtbitmap searches. So it's not > like garbled values result in metadata inconsistency. IOWs, it's > apparently benign. > > IOWs, how much does anyone care about improving on Linus' fixup? I'd really like to see the cast of a pointer to a struct type to a scalar gone, because those tend to hide bugs. I'm not going to bother you too much with it, promised.