On Thu, Nov 09, 2023 at 05:51:50AM +0100, Christoph Hellwig wrote: > On Wed, Nov 08, 2023 at 02:52:00PM -0800, Darrick J. Wong wrote: > > > Also, xfs people may obviously have other preferences for how to deal > > > with the whole "now using tv_sec in the VFS inode as a 64-bit sequence > > > number" thing, and maybe you prefer to then update my fix to this all. > > > But that horrid casts certainly wasn't the right way to do it. > > > > Yeah, I can work on that for the rt modernization patchset. > > As someone who has just written some new code stealing this trick I > actually have a todo list item to make this less horrible as the cast > upset my stomache. But shame on me for not actually noticing that it > is buggy as well (which honestly should be the standard assumption for > casts like this). Dave and I started looking at this too, and came up with: For rtgroups filesystems, what if rtpick simply rotored the rtgroups? And what if we didn't bother persisting the rotor value, which would make this casting nightmare go away in the long run. It's not like we persist the agi rotors. --D
