On Mon, Nov 06, 2023 at 02:15:42 PM -0800, Darrick J. Wong wrote: > On Mon, Nov 06, 2023 at 06:40:50PM +0530, Chandan Babu R wrote: >> From: Chandan Babu R <chandanbabu@xxxxxxxxxx> >> >> We will need two variants of read_header(), show_info() and restore() helper >> functions to support two versions of metadump formats. To this end, A future >> commit will introduce a vector of function pointers to work with the two >> metadump formats. To have a common function signature for the function >> pointers, this commit replaces the first argument of the previously listed >> function pointers from "struct xfs_metablock *" with "union >> mdrestore_headers *". >> >> Signed-off-by: Chandan Babu R <chandan.babu@xxxxxxxxxx> > > Looks pretty straightfoward now; thanks for fixing this... > Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> > Thanks for reviewing the entire patchset! -- Chandan
