> +/* Convert an ondisk bitmap word to its incore representation. */ > +static inline xfs_rtword_t > +xfs_rtbitmap_getword( > + struct xfs_buf *bp, > + unsigned int index) > +{ > + union xfs_rtword_raw *word = xfs_rbmblock_wordptr(bp, index); > + > + return word->old; > +} > + > +/* Set an ondisk bitmap word from an incore representation. */ > +static inline void > +xfs_rtbitmap_setword( > + struct xfs_buf *bp, > + unsigned int index, > + xfs_rtword_t value) > +{ > + union xfs_rtword_raw *word = xfs_rbmblock_wordptr(bp, index); > + > + word->old = value; > +} Before getting rid of xfs_rbmblock_wordptr I initially did this as: return xfs_rbmblock_wordptr(bp, index)->old; and xfs_rbmblock_wordptr(bp, index)->old = value; which looks a little neater to me. Otherwise looks good: Signed-off-by: Christoph Hellwig <hch@xxxxxx>