Hi all, Since the rtbitmap and rtsummary accessor functions have proven more controversial than the rest of the macro refactoring, split the patchset into two to make review easier. v1.1: various cleanups suggested by hch v1.2: rework the accessor functions to reduce the amount of cursor tracking required, and create explicit bitmap/summary logging functions If you're going to start using this code, I strongly recommend pulling from my git trees, which are linked below. With a bit of luck, this should all go splendidly. Comments and questions are, as always, welcome. --D kernel git tree: https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=refactor-rtbitmap-accessors-6.7 --- fs/xfs/libxfs/xfs_format.h | 16 +++ fs/xfs/libxfs/xfs_rtbitmap.c | 200 ++++++++++++++++++++++-------------------- fs/xfs/libxfs/xfs_rtbitmap.h | 62 ++++++++++++- fs/xfs/scrub/rtsummary.c | 30 ++++-- fs/xfs/scrub/trace.c | 1 fs/xfs/scrub/trace.h | 10 +- fs/xfs/xfs_ondisk.h | 4 + fs/xfs/xfs_rtalloc.c | 17 +--- 8 files changed, 216 insertions(+), 124 deletions(-)