On Fri, Oct 13, 2023 at 07:53:24AM +0200, Christoph Hellwig wrote: > On Thu, Oct 12, 2023 at 11:20:30AM -0700, Darrick J. Wong wrote: > > > Random rambling: there is a fairly large chunk of code duplicated > > > here. Maybe the caching series and/or Dave's suggest args cleanup > > > would be good opportunity to refactor it. Same for the next two > > > clusters of two chunks. > > > > Yeah, Dave and I will have to figure out how to integrate these two. > > I might just pull in his rtalloc_args patch at the end of this series. > > They way I understood his review of Omars patches isn't that he > has a rtalloc_args patch, but suggest adding that structure. > > I can take care of that after your series and Omar has landed, together > with the bitmap/summary access abstraction. Ah. I stg import'd Dave's suggestionpatch and it more or less applied, so it's already in the work branch. It also reduced Omar's patchset quite a bit. --D