On Wed, Oct 11, 2023 at 11:06:45AM -0700, Darrick J. Wong wrote:
> @@ -181,7 +181,7 @@ xfs_rtfind_back(
> return error;
> }
> bufp = bp->b_addr;
> - word = XFS_BLOCKWMASK(mp);
> + word = mp->m_blockwsize - 1;
> b = &bufp[word];
> } else {
> /*
> @@ -227,7 +227,7 @@ xfs_rtfind_back(
> return error;
> }
> bufp = bp->b_addr;
> - word = XFS_BLOCKWMASK(mp);
> + word = mp->m_blockwsize - 1;
> b = &bufp[word];
> } else {
Random rambling: there is a fairly large chunk of code duplicated
here. Maybe the caching series and/or Dave's suggest args cleanup
would be good opportunity to refactor it. Same for the next two
clusters of two chunks.
The patch itself looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
