On Mon, Sep 25, 2023 at 02:59:04PM -0700, Darrick J. Wong wrote: > Hi all, > > xfs_db doesn't even try to use directio to access block devices. This > is rather strange, since mkfs, copy, and repair use it. Modify xfs_db > to set LIBXFS_DIRECT so that we don't have to deal with the bdev > pagecache being out of sync with what the kernel might have written > directly to the block device. > > While we're at it, if we're using directio to the block device, don't > fail if we can't set the bufferhead size to the sectorsize, because > we're not using the pagecache anyway. > > If you're going to start using this code, I strongly recommend pulling > from my git trees, which are linked below. > > This has been running on the djcloud for months with no problems. Enjoy! > Comments and questions are, as always, welcome. > > --D The series looks good, thanks! Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx> Carlos > > xfsprogs git tree: > https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=db-use-directio > --- > db/init.c | 1 + > libxfs/init.c | 8 ++++++-- > 2 files changed, 7 insertions(+), 2 deletions(-) >
