Re: [PATCHSET v26.2 0/3] xfsprogs: force rebuilding of metadata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 25, 2023 at 02:58:44PM -0700, Darrick J. Wong wrote:
> Hi all,
> 
> This patchset adds a new IFLAG to the scrub ioctl so that userspace can
> force a rebuild of an otherwise consistent piece of metadata.  This will
> eventually enable the use of online repair to relocate metadata during a
> filesystem reorganization (e.g. shrink).  For now, it facilitates stress
> testing of online repair without needing the debugging knobs to be
> enabled.

Series look fine, although it requires a libxfs-sync to v6.6 before it can be
applied/tested.

Once I do a libxfs sync for v6.6 I'll apply/test this series.

By now, consider it a conditional RwB :)

Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>

Carlos

> 
> If you're going to start using this code, I strongly recommend pulling
> from my git trees, which are linked below.
> 
> This has been running on the djcloud for months with no problems.  Enjoy!
> Comments and questions are, as always, welcome.
> 
> --D
> 
> kernel git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=repair-force-rebuild
> 
> xfsprogs git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=repair-force-rebuild
> 
> fstests git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=repair-force-rebuild
> ---
>  io/scrub.c        |   24 ++++++++++++++-------
>  man/man8/xfs_io.8 |    3 +++
>  scrub/phase1.c    |   28 ++++++++++++++++++++++++
>  scrub/scrub.c     |   61 ++++++++++++++++++++++++++++-------------------------
>  scrub/scrub.h     |    1 +
>  scrub/xfs_scrub.c |    3 +++
>  scrub/xfs_scrub.h |    1 +
>  7 files changed, 84 insertions(+), 37 deletions(-)
> 



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux