Re: [PATCH 1/1] xfs/018: make sure that larp mode actually works

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 25, 2023 at 02:42:46PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
> 
> Skip this test if larp mode doesn't work.
> 
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
>  tests/xfs/018 |   13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> 
> diff --git a/tests/xfs/018 b/tests/xfs/018
> index 1ef51a2e61..73040edc92 100755
> --- a/tests/xfs/018
> +++ b/tests/xfs/018
> @@ -71,6 +71,17 @@ create_test_file()
>  	done
>  }
>  
> +require_larp()
> +{
> +	touch $SCRATCH_MNT/a
> +
> +	# Set attribute, being careful not to include the trailing newline
> +	# in the attr value.
> +	echo -n "attr_value" | ${ATTR_PROG} -s "attr_name" $SCRATCH_MNT/a 2>&1 | \
> +		grep 'Operation not supported' && \
> +		_notrun 'LARP not supported on this filesystem'

"rm -f $SCRATCH_MNT/a" ? although that's not necessary :)

Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>

> +}
> +
>  # real QA test starts here
>  _supported_fs xfs
>  
> @@ -112,6 +123,8 @@ _scratch_mount
>  testdir=$SCRATCH_MNT/testdir
>  mkdir $testdir
>  
> +require_larp
> +
>  # empty, inline
>  create_test_file empty_file1 0
>  test_attr_replay empty_file1 "attr_name" $attr64 "s" "larp"
> 




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux