On Tue, Sep 12, 2023 at 08:38:24AM -0700, Darrick J. Wong wrote: > On Tue, Sep 12, 2023 at 06:18:45PM +0300, Dan Carpenter wrote: > > The shmem_file_setup() function can't return NULL so there is no need > > to check and doing so is a bit confusing. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > --- > > No fixes tag because this is not a bug, just some confusing code. > > Please don't re-send patches that have already been presented here. > https://lore.kernel.org/linux-xfs/20230824161428.GO11263@frogsfrogsfrogs/ > Should we set an error code? These kinds of impossible error situations are hard to handle correctly. Like there are some places were we work around bugs in driver code where we can trust them to return error pointers and that's totally a valid thing. But here it's a very puzzling thing. regards, dan carpenter
