The shmem_file_setup() function can't return NULL so there is no need to check and doing so is a bit confusing. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> --- No fixes tag because this is not a bug, just some confusing code. fs/xfs/scrub/xfile.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/xfs/scrub/xfile.c b/fs/xfs/scrub/xfile.c index d98e8e77c684..71779d81cad7 100644 --- a/fs/xfs/scrub/xfile.c +++ b/fs/xfs/scrub/xfile.c @@ -70,8 +70,6 @@ xfile_create( return -ENOMEM; xf->file = shmem_file_setup(description, isize, 0); - if (!xf->file) - goto out_xfile; if (IS_ERR(xf->file)) { error = PTR_ERR(xf->file); goto out_xfile; -- 2.39.2