Re: [PATCH] xfs: delete some dead code in xfile_create()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/12/23 10:38 AM, Darrick J. Wong wrote:
On Tue, Sep 12, 2023 at 06:18:45PM +0300, Dan Carpenter wrote:
The shmem_file_setup() function can't return NULL so there is no need
to check and doing so is a bit confusing.

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
No fixes tag because this is not a bug, just some confusing code.

Please don't re-send patches that have already been presented here.
https://lore.kernel.org/linux-xfs/20230824161428.GO11263@frogsfrogsfrogs/

FWIW, I side with Dan's argument.  shmem_file_setup() *does not*
return NULL.  If it ever *did* return NULL, it would be up to the
person who makes that happen to change all callers to check for NULL.

The current code *suggests* that it could return NULL, which
is not correct.

					-Alex


--D

  fs/xfs/scrub/xfile.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/fs/xfs/scrub/xfile.c b/fs/xfs/scrub/xfile.c
index d98e8e77c684..71779d81cad7 100644
--- a/fs/xfs/scrub/xfile.c
+++ b/fs/xfs/scrub/xfile.c
@@ -70,8 +70,6 @@ xfile_create(
  		return -ENOMEM;
xf->file = shmem_file_setup(description, isize, 0);
-	if (!xf->file)
-		goto out_xfile;
  	if (IS_ERR(xf->file)) {
  		error = PTR_ERR(xf->file);
  		goto out_xfile;
--
2.39.2





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux