On Tue, Aug 08, 2023 at 09:15:50AM -0700, Christoph Hellwig wrote: > As a rule of thumb everything allocated to the fs_context and moved into > the super_block should be freed by ->kill_sb so that the teardown > handling doesn't need to be duplicated between the fill_super error > path and put_super. Implement a XFS-specific kill_sb method to do that. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- Looks good to me, Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx> For filesystems on the new mount api it's always nice if the rules can simply be made: * prior to sget_fc() succeeding fc->s_fs_info and freed in fs_context_operations->free() * after sget_fc() succeeding fc->s_fs_info transfered to sb->s_fs_info and freed in fs_type->kill_sb()
