On Tue, Aug 01, 2023 at 05:01:46 PM -0700, Darrick J. Wong wrote: > On Mon, Jul 24, 2023 at 10:05:23AM +0530, Chandan Babu R wrote: >> We will need two variants of read_header(), show_info() and restore() helper >> functions to support two versions of metadump formats. To this end, A future >> commit will introduce a vector of function pointers to work with the two >> metadump formats. To have a common function signature for the function >> pointers, this commit replaces the first argument of the previously listed >> function pointers from "struct xfs_metablock *" with "union >> mdrestore_headers *". >> >> Signed-off-by: Chandan Babu R <chandan.babu@xxxxxxxxxx> > > The overall code changes look fine to me, but I'm a little mystified why > the *previous* patch introduces union mdrestore_headers and the > mdrestore ops without using either of them. > > IOWs, I think you could delete patch 18, move the union definition into > this patch, and move the mdrestore ops definitions that used to be in > patch 18 into patch 20. > You are right. I will make the changes suggested above. -- chandan
