On Tue, May 23, 2023 at 10:40:53 AM -0700, Darrick J. Wong wrote: > On Tue, May 23, 2023 at 02:30:41PM +0530, Chandan Babu R wrote: >> Signed-off-by: Chandan Babu R <chandan.babu@xxxxxxxxxx> > > This should be in the previous patch. > Ok. >> --- >> man/man8/xfs_metadump.8 | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/man/man8/xfs_metadump.8 b/man/man8/xfs_metadump.8 >> index c0e79d779..23695c768 100644 >> --- a/man/man8/xfs_metadump.8 >> +++ b/man/man8/xfs_metadump.8 >> @@ -11,6 +11,9 @@ xfs_metadump \- copy XFS filesystem metadata to a file >> ] [ >> .B \-l >> .I logdev >> +] [ >> +.B \-v >> +.I version >> ] >> .I source >> .I target >> @@ -74,6 +77,9 @@ metadata such as filenames is not considered sensitive. If obfuscation >> is required on a metadump with a dirty log, please inform the recipient >> of the metadump image about this situation. >> .PP >> +The contents of an external log device can be dumped only when using the v2 >> +format. Metadump in v2 format can be generated by passing the "-v 2" option. > > Please start each sentence on a separate line. Does it need to be formatted as shown below? The contents of an external log device can be dumped only when using the v2 format. Metadump in v2 format can be generated by passing the "-v 2" option. > > This also should mention that metadump will pick v2 if there's no > explicit -v option and the fs has an external log. Ok. I will include that as part of the description. -- chandan
