On Tue, May 23, 2023 at 11:10:56 AM -0700, Darrick J. Wong wrote: > On Tue, May 23, 2023 at 02:30:50PM +0530, Chandan Babu R wrote: >> Signed-off-by: Chandan Babu R <chandan.babu@xxxxxxxxxx> >> --- >> man/man8/xfs_mdrestore.8 | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/man/man8/xfs_mdrestore.8 b/man/man8/xfs_mdrestore.8 >> index 72f3b2977..a53ac84d0 100644 >> --- a/man/man8/xfs_mdrestore.8 >> +++ b/man/man8/xfs_mdrestore.8 >> @@ -5,6 +5,9 @@ xfs_mdrestore \- restores an XFS metadump image to a filesystem image >> .B xfs_mdrestore >> [ >> .B \-gi >> +] [ >> +.B \-l >> +.I logdev >> ] >> .I source >> .I target >> @@ -49,6 +52,11 @@ Shows metadump information on stdout. If no >> is specified, exits after displaying information. Older metadumps man not >> include any descriptive information. >> .TP >> +.B \-l " logdev" >> +Metadump in v2 format can contain metadata dumped from an external log. In >> +such a scenario, the user has to provide a device to which the log device >> +contents from the metadump file are copied. > > Please start sentences on a new line. > > Also, this ought to be folded into the previous patch. > > Otherwise the manpage additions look reasonable to me. Thanks for your valuable review comments! -- chandan
