On Mon, May 22, 2023 at 10:59:17PM -0700, Christoph Hellwig wrote: > On Sat, May 20, 2023 at 05:36:01PM +0100, Matthew Wilcox (Oracle) wrote: > > +#define FGP_ORDER(fgp) ((fgp) >> 26) /* top 6 bits */ > > Why don't we just add a new argument for the order? Because it already takes four arguments and has dozens of callers, most of which would have the uninformative '0' added to them?