On Sun, Jun 26, 2022 at 08:46:52PM -0700, Darrick J. Wong wrote: > On Mon, Jun 27, 2022 at 11:23:55AM +1000, Dave Chinner wrote: > > On Sun, Jun 26, 2022 at 03:03:58PM -0700, Darrick J. Wong wrote: > > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > > > Now that we've established (again!) that empty xattr leaf buffers are > > > ok, we no longer need to bhold them to transactions when we're creating > > > new leaf blocks. Get rid of the entire mechanism, which should simplify > > > the xattr code quite a bit. > > > > > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > Why? > > The original justification for using bhold here was to prevent the AIL > from trying to write the empty leaf block into the fs during the brief > time that we release the buffer lock. The reason for /that/ was to > prevent recovery from tripping over the empty ondisk block. Ok. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx
