On Sun, Jun 26, 2022 at 03:03:58PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > Now that we've established (again!) that empty xattr leaf buffers are > ok, we no longer need to bhold them to transactions when we're creating > new leaf blocks. Get rid of the entire mechanism, which should simplify > the xattr code quite a bit. > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> Why? This code isn't there for correctness - it's just a way of avoiding needing to look up and lock the buffer immediately after we just created it and had a reference to it. This is a valid use of xfs_trans_bhold(), so I'm not convinced that removing it makes the code better. Simpler, yes, but not necessarily better. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
