On Sun, Jun 05, 2022 at 05:02:33PM -0700, Darrick J. Wong wrote: > On Mon, Jun 06, 2022 at 08:29:40AM +1000, Dave Chinner wrote: > > On Sun, Jun 05, 2022 at 09:35:43AM -0700, Darrick J. Wong wrote: > > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > > > It is vitally important that we preserve the state of the NREXT64 inode > > > flag when we're changing the other flags2 fields. > > > > > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > > > --- > > > fs/xfs/xfs_ioctl.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > Fixes tag? > > Does this really need one? NREXT64 is still experimental, none of this > code is in any released kernel, In my opinion, absolutely not. But after just spending a large part of the last cycle fielding unjustified complaint after complaint that we didn't get everything exactly perfect for every possible unforseen future uses for commit messages and cover letters.... > and I'm not even sure what would be a > good target -- the patch that introduced XFS_DIFLAG_NREXT64? 9b7d16e34bbe xfs: Introduce XFS_DIFLAG2_NREXT64 and associated helpers Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
