On Mon, Jun 06, 2022 at 08:29:40AM +1000, Dave Chinner wrote:
> On Sun, Jun 05, 2022 at 09:35:43AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@xxxxxxxxxx>
> >
> > It is vitally important that we preserve the state of the NREXT64 inode
> > flag when we're changing the other flags2 fields.
> >
> > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> > ---
> > fs/xfs/xfs_ioctl.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Fixes tag?
Does this really need one? NREXT64 is still experimental, none of this
code is in any released kernel, and I'm not even sure what would be a
good target -- the patch that introduced XFS_DIFLAG_NREXT64?
> > diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
> > index 5a364a7d58fd..0d67ff8a8961 100644
> > --- a/fs/xfs/xfs_ioctl.c
> > +++ b/fs/xfs/xfs_ioctl.c
> > @@ -1096,7 +1096,8 @@ xfs_flags2diflags2(
> > {
> > uint64_t di_flags2 =
> > (ip->i_diflags2 & (XFS_DIFLAG2_REFLINK |
> > - XFS_DIFLAG2_BIGTIME));
> > + XFS_DIFLAG2_BIGTIME |
> > + XFS_DIFLAG2_NREXT64));
> >
> > if (xflags & FS_XFLAG_DAX)
> > di_flags2 |= XFS_DIFLAG2_DAX;
>
> Otherwise looks good.
>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
Thx. :)
--D
>
> -Dave.
> --
> Dave Chinner
> david@xxxxxxxxxxxxx
