On Thu, May 05, 2022 at 09:05:42AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > Catherine's recent changes to xfs/019 exposed a bug in how libxfs > handles setgid bits. mkfs reads the desired gid in from the protofile, > but if the parent directory is setgid, it will override the user's > setting and (re)set the child's gid to the parent's gid. Overriding > user settings is (probably) not the desired mode of operation, so create > a flag to struct cred to force the gid in the protofile. > > It looks like this has been broken since ~2005. Ouch. The fix looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
