Re: [PATCH 5/6] mkfs: round log size down if rounding log start up causes overflow

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 05, 2022 at 09:05:36AM -0700, Darrick J. Wong wrote:
> +	/*
> +	 * If the end of the log has been rounded past the end of the AG,
> +	 * reduce logblocks by a stripe unit to try to get it back under EOAG.
> +	 */
> +	if (!libxfs_verify_fsbext(mp, cfg->logstart, cfg->logblocks) &&
> +	    cfg->logblocks > sunit) {
> +		cfg->logblocks -= sunit;
> +	}

The curly braces look a little out of place here, but otherwise this
looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux