On 11 Apr 2022 at 06:01, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
>
> 5.18 w/ std=gnu11 compiled with gcc-5 wants flags stored in unsigned
> fields to be unsigned.
>
Looks good.
Reviewed-by: Chandan Babu R <chandan.babu@xxxxxxxxxx>
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
> fs/xfs/xfs_log_priv.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index 401cdc400980..438df48a84c4 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -51,8 +51,8 @@ enum xlog_iclog_state {
> /*
> * In core log flags
> */
> -#define XLOG_ICL_NEED_FLUSH (1 << 0) /* iclog needs REQ_PREFLUSH */
> -#define XLOG_ICL_NEED_FUA (1 << 1) /* iclog needs REQ_FUA */
> +#define XLOG_ICL_NEED_FLUSH (1u << 0) /* iclog needs REQ_PREFLUSH */
> +#define XLOG_ICL_NEED_FUA (1u << 1) /* iclog needs REQ_FUA */
>
> #define XLOG_ICL_STRINGS \
> { XLOG_ICL_NEED_FLUSH, "XLOG_ICL_NEED_FLUSH" }, \
> @@ -62,7 +62,7 @@ enum xlog_iclog_state {
> /*
> * Log ticket flags
> */
> -#define XLOG_TIC_PERM_RESERV 0x1 /* permanent reservation */
> +#define XLOG_TIC_PERM_RESERV (1u << 0) /* permanent reservation */
>
> #define XLOG_TIC_FLAGS \
> { XLOG_TIC_PERM_RESERV, "XLOG_TIC_PERM_RESERV" }
> @@ -165,7 +165,7 @@ typedef struct xlog_ticket {
> char t_ocnt; /* original count : 1 */
> char t_cnt; /* current count : 1 */
> char t_clientid; /* who does this belong to; : 1 */
> - char t_flags; /* properties of reservation : 1 */
> + uint8_t t_flags; /* properties of reservation : 1 */
>
> /* reservation array fields */
> uint t_res_num; /* num in array : 4 */
--
chandan
