On Tue, Apr 12, 2022 at 12:56:30PM +0530, Chandan Babu R wrote: > On 11 Apr 2022 at 06:01, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > 5.18 w/ std=gnu11 compiled with gcc-5 wants flags stored in unsigned > > fields to be unsigned. > > > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > > --- > > [...] > > > @@ -350,12 +350,12 @@ static inline bool xfs_inode_has_bigtime(struct xfs_inode *ip) > > */ > > #define XFS_IOLOCK_SHIFT 16 > > #define XFS_IOLOCK_MAX_SUBCLASS 3 > > -#define XFS_IOLOCK_DEP_MASK 0x000f0000 > > +#define XFS_IOLOCK_DEP_MASK 0x000f0000u > > > > #define XFS_MMAPLOCK_SHIFT 20 > > #define XFS_MMAPLOCK_NUMORDER 0 > > #define XFS_MMAPLOCK_MAX_SUBCLASS 3 > > -#define XFS_MMAPLOCK_DEP_MASK 0x00f00000 > > +#define XFS_MMAPLOCK_DEP_MASK 0x00f00000u > > > > #define XFS_ILOCK_SHIFT 24 > > #define XFS_ILOCK_PARENT_VAL 5 > > Why isn't the value of XFS_ILOCK_DEP_MASK marked as unsigned? Because I'm blind as a bat at the best of times... :) Good catch - I'll fix it up. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
