On Thu, Nov 11, 2021 at 12:00:04AM -0800, Christoph Hellwig wrote:
> On Tue, Nov 09, 2021 at 12:50:43PM +1100, Dave Chinner wrote:
> > - if (optype & XLOG_START_TRANS) {
> > + if (optype) {
>
> Shouldn't this explicitly check for XLOG_START_TRANS or
> XLOG_UNMOUNT_TRANS? The cont flags can't really happen here, so it
> won't make a functional difference, but it would document the intent
> much better.
This scaffolding disappears completely in a couple of patches time,
so it's not worth the effort to polishing it to perfection.
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Thanks!
--
Dave Chinner
david@xxxxxxxxxxxxx
